duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.79k stars 405 forks source link

Refactor view hierarchy to achieve dax dialog animation growing/shrinking #3045

Closed alessandroboron closed 9 hours ago

alessandroboron commented 3 days ago

Task/Issue URL: https://app.asana.com/0/1206329551987282/1207736844779819/f CC: @SabrinaTardio

Description:

This PR refactors the view hierarchy to make the UI Dialog seem to update the same view and match the Android animation. I also cleaned up a bit by moving/renaming some views.

https://github.com/duckduckgo/iOS/assets/1089358/cfdb15b1-021b-439d-815a-005b93ee4cda

Steps to test this PR:

  1. Run the new Onboarding Intro flow
  2. Check that the animation from the intro dialog to the browser comparison dialog looks nice and smooth.

Definition of Done (Internal Only):

Copy Testing:

Orientation Testing:

Device Testing:

OS Testing:

Theme Testing:


Internal references:

Software Engineering Expectations Technical Design Template

github-actions[bot] commented 3 days ago

:no_entry_sign: The Asana task linked in the PR description is not added to iOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • :warning: Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to iOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.