duckduckgo / iOS

DuckDuckGo iOS Application
https://itunes.apple.com/us/app/duckduckgo-privacy-browser/id663592361?mt=8
Apache License 2.0
1.79k stars 405 forks source link

Update Sync error pixels #3046

Closed ayoy closed 3 days ago

ayoy commented 3 days ago

Task/Issue URL: https://app.asana.com/0/1201621708115095/1207559244852258/f

Description: Rename count limit exceeded as object limit exceeded and add "Too Many Requests" pixels.

Steps to test this PR: Since this change doesn't modify any logic related to processing errors, it's enough that you verify that pixel names are correct. The simplest is to add this snippet of code at the bottom of AppDelegate's applicationDidFinishLaunching:

Pixel.fire(pixel: .syncBookmarksObjectLimitExceededDaily)
Pixel.fire(pixel: .syncCredentialsObjectLimitExceededDaily)
Pixel.fire(pixel: .syncBookmarksRequestSizeLimitExceededDaily)
Pixel.fire(pixel: .syncCredentialsRequestSizeLimitExceededDaily)
Pixel.fire(pixel: .syncBookmarksTooManyRequestsDaily)
Pixel.fire(pixel: .syncCredentialsTooManyRequestsDaily)
Pixel.fire(pixel: .syncSettingsTooManyRequestsDaily)

Then run the app and check the log. Compare output with what's expected in the Asana task.

Definition of Done (Internal Only):

Copy Testing:

Orientation Testing:

Device Testing:

OS Testing:

Theme Testing:


Internal references:

Software Engineering Expectations Technical Design Template