duckduckgo / macos-browser

DuckDuckGo macOS Browser
Apache License 2.0
246 stars 9 forks source link

Ignore accents when doing a bookmark search #3255

Closed jotaemepereira closed 1 month ago

jotaemepereira commented 1 month ago

Task/Issue URL: https://app.asana.com/0/1203972458584429/1208262956542583/f Tech Design URL: CC:

Description

Acceptance criteria AC#1 Given a user with a bookmark with an accent, for example café , when searching for cafe we should return the bookmark with the accent.

AC#2 Given a user with a bookmark without an accent, for example cafe , when searching for café we should return the bookmark without the accent, ignoring the accent on the search query.

AC#3 Given a user with a bookmark with symbols, for example, Site • Login , when searching for site login then we should return the bookmark with the symbol

AC#4 Given a user with a bookmark without symbols, for example, Site Login , when searching for site • login then we should return the bookmark without the symbol ignoring the symbol in the search query.

Steps to test this PR

Accents

  1. Add a bookmark, and in the bookmark name, add it with an accent. For example, café
  2. Go to the bookmarks manager or the bookmark panel and start a search
  3. Search for cafe (without the accent)
  4. It should return the result
  5. Do the same thing but viceversa. Create a bookmark without an accent, for example, cafe, and search for café, the accent should be ignored and the result should be returned in the search.

Symbols

  1. Add a bookmark, and in the bookmark name, add it with a symbol. For example, Site • Login
  2. Go to the bookmarks manager or the bookmark panel and start a search
  3. Search for site login (without the symbol)
  4. It should return the result
  5. Do the same thing but viceversa.

Definition of Done:

Internal references:

Pull Request Review Checklist Software Engineering Expectations Technical Design Template Pull Request Documentation