Closed amddg44 closed 1 month ago
Warnings | |
---|---|
:warning: | PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible. |
Messages | |
---|---|
:book: | You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See [Localization Guidelines](https://app.asana.com/0/0/1206727265537758/f) for more information. |
Generated by :no_entry_sign: dangerJS against 039e77799b37fd23ba27fda8474fda5897ef6ffd
Task/Issue URL: https://app.asana.com/0/1208273769335188/1207344337317796/f Tech Design URL: CC:
Description: Adds sync promotion to passwords & bookmarks screens
Steps to test this PR: See https://app.asana.com/0/1208273769335188/1208283593882915/f description for screenshots of final designs
Sync Promo for Passwords
sync_promotion_displayed_macos_desktop
is fired with source =passwords
sync_promotion_confirmed_macos_desktop
was fired with source =passwords
sync_promotion_dismissed_macos_desktop
was fired with source =passwords
Sync Promo for Bookmarks
sync_promotion_displayed_macos_desktop
is fired with source =bookmarks
sync_promotion_confirmed_macos_desktop
was fired with source =bookmarks
sync_promotion_dismissed_macos_desktop
was fired with source =bookmarks
Sync Setup
<!— Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the
DO NOT MERGE
label (particularly if it's a draft) If it's pending Product Review/PFR, please add thePending Product Review
label.If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. —>
Definition of Done:
—
Internal references:
Pull Request Review Checklist Software Engineering Expectations Technical Design Template Pull Request Documentation