Closed jotaemepereira closed 1 day ago
LGTM to address the specific issue. I believe I encountered a related issue which was:
- Have lots of bookmark folders with child folders also
- Scroll to bottom, expand parent and child folder
- Search
- When cancel search, position is not maintained, we are back to the top
Maybe this is an issue specific to child folders?
Anyway, you can test further, but the work here addresses this specific issue so this PR is good. 👍🏼
Thanks @aataraxiaa ! I will take another look, I tried that flow, and the position was maintained. Maybe we are hitting an edge case somehow.
https://github.com/user-attachments/assets/5382b319-842e-4b3a-be17-d9157ab2b380
Task/Issue URL: https://app.asana.com/0/1204006570077678/1208262956542585/f Tech Design URL: CC:
Description: Given a user on the bookmarks panel, when the user starts a search and comes back to the tree view, then the selected, collapsed and expanded folders or bookmarks should be maintained.
https://github.com/user-attachments/assets/5ae781ab-e6c5-4e48-87e1-7eea9b267fda
Steps to test this PR:
Definition of Done:
—
Internal references:
Pull Request Review Checklist Software Engineering Expectations Technical Design Template Pull Request Documentation