search

duckduckgo / macos-browser

DuckDuckGo macOS Browser
Apache License 2.0
246 stars 9 forks source link

Fix scrolling to new tab when tabs overflow #3290

Closed ayoy closed 1 month ago

ayoy commented 1 month ago

Task/Issue URL: https://app.asana.com/0/1201048563534612/1208326825362864/f

Description: Perform all updates of the collection view in a batch and only scroll to the new tab from the completion handler.

Steps to test this PR:

  1. Open so many new tabs that the tab bar overflow mode is enabled and arrow buttons are present
  2. From the Open new tab via context menu or cmd+click
  3. Verify that the tab bar is scrolled to show the newly opened (inactive) tab.

Definition of Done:

Internal references:

Pull Request Review Checklist Software Engineering Expectations Technical Design Template Pull Request Documentation

ayoy commented 1 month ago

Turns out this breaks opening Zoom links, so let me work on it a bit more.