Migrate hotfix release to fastlane - Githubissues

duckduckgo / macos-browser

DuckDuckGo macOS Browser

Apache License 2.0

249 stars 10 forks source link

Migrate hotfix release to fastlane #3579

Closed kshann closed 23 hours ago

kshann commented 5 days ago

Task/Issue URL: https://app.asana.com/0/1205419239275955/1208658415307255/f Tech Design URL: CC:

Description:

Update hotfix release flow to use new Fastlane actions
build_hotfix_release.yml executes the same action we use in start_new_release. I didn't explicitly test this flow here but. I followed suit with what has been done in publish_dmg_release.yml and the action was tested in https://github.com/duckduckgo/macos-browser/pull/3563

Optional E2E tests:

[ ] Run PIR E2E tests Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

See successful run
Second test after PR feedback on automation PR

Definition of Done:

[ ] Does this PR satisfy our Definition of Done?

Internal references:

Pull Request Review Checklist Software Engineering Expectations Technical Design Template Pull Request Documentation

kshann commented 2 days ago

When I removed the is_ci section in ddg-automation the hotfix branch kept failing to create due to

! [remote rejected]     hotfix/1.114.1 -> hotfix/1.114.1 (refusing to allow a GitHub App to create or update workflow `.github/workflows/sync_end_to_end.yml` without `workflows` permission)`

Fixed by checking out with the elevated token in the workflow which then allows it to push the hotfix branch properly in the automation.