Trigger the Cookie Hidden animation early for filterlist rules - Githubissues

duckduckgo / macos-browser

DuckDuckGo macOS Browser

Apache License 2.0

249 stars 10 forks source link

Trigger the Cookie Hidden animation early for filterlist rules #3584

Open muodov opened 4 days ago

muodov commented 4 days ago

Task/Issue URL: https://app.asana.com/0/72649045549333/1208825971888846/f Tech Design URL: https://app.asana.com/0/1201844467387842/1208738659527990/f CC:

Description:

Make sure to show the CPM animation when cosmetic filterlist rules match.
This means that you will see "Cookie Hidden" animation if filterlist cosmetic rule hides something, but might see another one if an active rule matches later.
This is dependent on CPM changes, so when testing, please use this branch: max/autoconsent-filterlist-animation-review, or the test build in the Ship Review.

Optional E2E tests:

[ ] Run PIR E2E tests Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR: See the steps in Ship review: https://app.asana.com/0/72649045549333/1208825971888846/f

Definition of Done:

[ ] Does this PR satisfy our Definition of Done?

Internal references:

Pull Request Review Checklist Software Engineering Expectations Technical Design Template Pull Request Documentation