Simplify User Agent logic and update unit tests - Githubissues

duckduckgo / macos-browser

DuckDuckGo macOS Browser

Apache License 2.0

249 stars 10 forks source link

Simplify User Agent logic and update unit tests #3586

Closed ayoy closed 4 days ago

ayoy commented 4 days ago

Task/Issue URL: https://app.asana.com/0/1201037661562251/1208568177174606/f CC: @jonathanKingston

Description: This change updates User Agent rules as follows:

The default UA is now DDG-branded and it's applied to all web, including duckduckgo.com.
defaultPolicy privacy config item is no longer supported.
2 types of privacy-config-provided exceptions are supported: webViewDefault (using WebKit default UA) and defaultSites (using Safari UA).

Steps to test this PR:

Open https://duckduckgo.com and verify that you see a minimal homepage (without macOS browser download CTA as seen in Safari)
Open this Kibana view and this Kibana view.
Search on SERP for samplesearchformacosbrowseruapullrequesttesting
Refresh Kibana and verify that agent reported for nginx access and pixels is ddg_mac_desktop (the same searches on a macOS browser release app would show empty user agent).

Definition of Done:

[ ] Does this PR satisfy our Definition of Done?

Internal references:

Pull Request Review Checklist Software Engineering Expectations Technical Design Template Pull Request Documentation