duckduckgo / macos-browser

DuckDuckGo macOS Browser
Apache License 2.0
249 stars 10 forks source link

Fix an issue that cause compilation failure #3587

Closed alessandroboron closed 3 days ago

alessandroboron commented 4 days ago

Task/Issue URL: https://app.asana.com/0/1201037661562251/1208822723600157/f

Description:

Fix compilation issue for Xcode 15 due to usage of [@retroactive](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0364-retroactive-conformance-warning.md#source-compatibility) keyword.

Silence the warning by fully qualifying the protocol name with module name.

Optional E2E tests:

Steps to test this PR:

  1. Ensure Xcode doesn’t show a warning for extension File: Swift.Equatable, Swift.Hashable

Definition of Done:


Internal references:

Pull Request Review Checklist Software Engineering Expectations Technical Design Template Pull Request Documentation