duckduckgo / macos-browser

DuckDuckGo macOS Browser
Apache License 2.0
249 stars 10 forks source link

Rename PhishingDetection to MaliciousSiteProtection #3588

Open mallexxx opened 3 days ago

mallexxx commented 3 days ago

Task/Issue URL: https://app.asana.com/0/1202406491309510/1208033567421351/f BSK PR: https://github.com/duckduckgo/BrowserServicesKit/pull/1091 Tech Design URL: CC:

Description:

Steps to test this PR:

  1. Activate Feature Flag override for malicious site protections in Debug -> Feature Flag overrides
  2. Visit https://privacy-test-pages.site/security/badware/phishing.html, validate phishing detection works without changes
  3. Validate ./scripts/update_phishing_detection_data.sh script works and updates data

Definition of Done:


Internal references:

Pull Request Review Checklist Software Engineering Expectations Technical Design Template Pull Request Documentation

github-actions[bot] commented 3 days ago
Warnings
:warning: PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
:book: You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See [Localization Guidelines](https://app.asana.com/0/0/1206727265537758/f) for more information.

Generated by :no_entry_sign: dangerJS against aca479c7e0fdee854ecacc2f5b3ec0cf05eb6d3e