Malware protection 2: API Client refactoring - Githubissues

duckduckgo / macos-browser

DuckDuckGo macOS Browser

Apache License 2.0

249 stars 10 forks source link

Malware protection 2: API Client refactoring #3595

Closed mallexxx closed 1 day ago

mallexxx commented 4 days ago

Task/Issue URL: https://app.asana.com/0/481882893211075/1208033567421351/f BSK PR: https://github.com/duckduckgo/BrowserServicesKit/pull/1092

Description:

Refactor APIClient to use Networking.APIRequestV2; implement generic request/response (BSK)

Optional E2E tests:

[ ] Run PIR E2E tests Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

Validate Phishing Protection change sets and Match API calls work as before

Definition of Done:

[ ] Does this PR satisfy our Definition of Done?

Internal references:

Pull Request Review Checklist Software Engineering Expectations Technical Design Template Pull Request Documentation