search

duckduckgo / p5-app-duckpan

DuckDuckHack OpenSource Development Application
http://metacpan.org/module/App::DuckPAN
Other
53 stars 47 forks source link

Duckpan broke #180

Closed killerfish closed 9 years ago

killerfish commented 9 years ago

Going to investigate, just opening this as an issue, as others might be facing this issue also.

sds

moollaza commented 9 years ago

@killerfish thanks for this -- I'm unable to replicate, have you been able to?

moollaza commented 9 years ago

Changing to Med priority, this only affects latest state of Code on Master, it's not affecting normal devs who are using the latest from CPAN.

moollaza commented 9 years ago

MintberryCruNCH on IRC gave these instructions to reproduce:

I'm still unable to reproduce but there's definitely something odd happening. After gettting the Goodie to show the first time, subsequent request don't produce the result on the page. I just see a normal SERP with no "Answer" tab. I'm going to look at how we're modifying the HTML...

moollaza commented 9 years ago

Update: Okay now I got it after trying again by restarting server with empty cache.

moollaza commented 9 years ago

I was wrong, this affects the currently release version as well -- Its a pretty niche bug so I'm not too worried but we definitely need to figure this out.

@killerfish @mwmiller I think we might need to modify the page for Goodies like we do in production. i.e. wait for the AnswerBar JS to run and then add the Goodie to the AnswerBar via JS

mwmiller commented 9 years ago

@killerfish This was pretty subtle. I had noticed some weirdness along these lines before, but always thought it was my (previously) improper cache. It was part of why I made the length checker on the downloaded assets. I hadn't noticed it since, but I guess I didn't actually know how to trigger the issue.

Thanks very much for the fix!