duckduckgo / p5-app-duckpan

DuckDuckHack OpenSource Development Application
http://metacpan.org/module/App::DuckPAN
Other
53 stars 47 forks source link

Redirect on HTTP Error breaks for flow for multiple IA triggering #191

Closed moollaza closed 9 years ago

moollaza commented 9 years ago

As noted here: https://github.com/duckduckgo/zeroclickinfo-spice/pull/1280#issuecomment-65737554

I realized the problem is that when multiple IA's trigger, any one fails, we capture the error code and redirect home, ignoring the fact that other IA's may have been waiting to give a response!

We should capture the error and create a warning on the front end in the same manner that I have setup for the Spice.failed() calls.

We can probably just append a <script> tag to the HTML that calls Spice.failed() and also passes along an additional message indicating what the HTTP error was.

cc// @killerfish

killerfish commented 9 years ago

Bummer! didnt consider that case, ill update accordingly.

moollaza commented 9 years ago

Thanks a lot @killerfish !

killerfish commented 9 years ago

Can you tell me some multiple instant answer case (which dont require keys), just need to test it out.

moollaza commented 9 years ago

I think AlternativeTo and NPM should work? I honestly just started making up random queries that combined trigger words. Look for IA's that always return in the Perl