search

duckduckgo / p5-app-duckpan

DuckDuckHack OpenSource Development Application
http://metacpan.org/module/App::DuckPAN
Other
53 stars 47 forks source link

Env Tests: Causing problems... #210

Closed moollaza closed 9 years ago

moollaza commented 9 years ago

New tests were recently written to verify that DuckPAN properly creates and modifies its env.ini file. Initially I ran into problems with failing tests (only on my dev machine!) that were related to the detection of the created files.

For some reason the tests didn't think the right files were there, but after checking for the files myself they were there and everything seemed to be working correctly.

More recently, when I ran the tests again, everything passed as expected across various machines so I released DuckPAN.

It seems a dev is now facing similar/related issues which I haven't figured out yet:

    #   Failed test 'setting DuckPAN env test to me'
    #   at /home/dax/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Test/Exception.pm line 346.
    #          got: 2
    #     expected: 0
Error open (<) on '/tmp/E83jjRbBra/env.ini': No such file or directory at t/system_duckpan.t line 39.
    # Child (env) exited without calling finalize()

#   Failed test 'env'
#   at /home/dax/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Test/Builder.pm line 279.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 2 just after 3.
t/system_duckpan.t ...... 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 1/3 subtests

For now I'll remove the error-prone tests (the env isn't terribly important and I'm confident everything works) and re-release DuckPAN. Would love to figure out what is causing the errant problems though.

/cc @killerfish

moollaza commented 9 years ago

Fixed in #211