search

duckduckgo / p5-app-duckpan

DuckDuckHack OpenSource Development Application
http://metacpan.org/module/App::DuckPAN
Other
53 stars 47 forks source link

Weird issue with goodies using share #229

Closed killerfish closed 9 years ago

killerfish commented 9 years ago

Issue: Goodies accessing the share directory fail to startup. How to reproduce:

  1. Create directory in the folder with your goodies repo named 't'
  2. Fire up any goodie using share dir e.g. duckpan server PeriodicTable

I think another issue like this popped up a while back, but i don’t recall it precisely. @moollaza do you remember which issue was that?

MrChrisW commented 9 years ago

@killerfish Interesting, I've just fired up and tested however I'm unable to reproduce. Can you clarify what you mean when you say "Create directory in the folder with your goodies repo named 't'" Where are you creating the directory named "t" ? in /share/goodie/periodic_table or elsewhere ?

killerfish commented 9 years ago

Sorry for the ambiguity, here is a SS weirdissue Im waiting on @moollaza since this might be replicate of a similar issue (i forgot).

MrChrisW commented 9 years ago

@killerfish Looks like a local issue, I've tested again:

screenshot2135

killerfish commented 9 years ago

@MrChrisW ill investigate this further. Im getting the same thing issuewithgoodies

MrChrisW commented 9 years ago

@killerfish Can you try updating your perl version? As per the duckpan message "v5.16.0> recommended" dobut it will resolve the issue but worth a try.

killerfish commented 9 years ago

@MrChrisW problem is with this case, which is ancient, and needs to be removed, i think. Making a PR on duckduckgo for this. //cc @moollaza oknow

MrChrisW commented 9 years ago

@killerfish :+1: sure, still strange I'm unable to replicate.

mintsoft commented 9 years ago

@MrChrisW FWIW my ddh environment is Perl 5.14.2 on Debian wheezy; never had a problem :+1:

MrChrisW commented 9 years ago

@mintsoft Cool, just trying to rule that out :smiley: @killerfish Finally I was able to reproduce the issue!!! That looks like the cause as it's checking the t dir above zeroclickinfo-goodies (root).

moollaza commented 9 years ago

Hey guys, thanks a lot for reporting this and thanks even more for making a PR @killerfish .

This is indeed a know bug, that crops up occasionally. I was about to say the problem exists somewhere in here: https://github.com/duckduckgo/duckduckgo/blob/master/lib/DDG/Meta/ShareDir.pm

As mentioned the problem occurs when a "/t" dir is a sibling to your repo dir AFAIK.