search

duckduckgo / p5-app-duckpan

DuckDuckHack OpenSource Development Application
http://metacpan.org/module/App::DuckPAN
Other
53 stars 47 forks source link

Non-fatal UTF-8 Error from Lint.pm #26

Closed moollaza closed 10 years ago

moollaza commented 11 years ago

/cc @yegg

@nospampleasemam after merging and testing your other UTF-8 fix everything seemed to be good, "g+ duckduckgo" worked for me, as well as "flip testing".

However, after testing your other PR's I noticed that when testing Quixey I received the same UTF-8 error as before:

Body must be bytes and should not contain wide characters (UTF-8 strings) at /home/zaahir/perl5/lib/perl5/Plack/Middleware/Lint.pm line 156

But this time it's non-fatal, as the plugin comes through and everything looks fine on the frontend:

image

Quixey also gets a lot of complaints from DuckPAN about tons of utf8 characters. This however has always been there, but I'm assuming its related to the problem: image

moollaza commented 10 years ago

Problems have now been fixed, better handling of UTF8 has been implemented.

The Quxey errors were due to IO::All attempting to UTF8 encode .png files.