search

duckduckgo / p5-app-duckpan

DuckDuckHack OpenSource Development Application
http://metacpan.org/module/App::DuckPAN
Other
53 stars 47 forks source link

DuckPAN renders (i) icon incorrectly #292

Closed mintsoft closed 8 years ago

mintsoft commented 8 years ago

image

I'm not sure why it's so poorly positioned?

Jedidiah commented 8 years ago

Adding overflow: visible; to .zcm__sep--h gets rid of the wee grey block, but I'm not sure why it's only an issue when running duckpin locally and not in production.

moollaza commented 8 years ago

@Jedidiah thanks for that, worst case, I'll see if we can add some custom CSS for DuckPAN, but I'd like to avoid that.

@bsstoner @jdorweiler do you know if we have any JS that modifies the dom to allow for the location of the i icon to be on the right side?

also, any ideas on why that grey block appears there? I suspect it has something to do with how we're modifying the answer bar...

GuiltyDolphin commented 8 years ago

@mintsoft I think I've figured out what's being changed, but I have no idea why!

screenshot from 2016-01-23 16 13 54

screenshot from 2016-01-23 16 12 08

For the icon:

screenshot from 2016-01-23 16 21 51

Working duckpan:

screenshot from 2016-01-23 16 11 59

Original duckpan:

screenshot from 2016-01-23 16 19 43

Beta:

screenshot from 2016-01-23 16 26 02

Also, what's up with Dax?

DuckPAN:

screenshot from 2016-01-23 16 23 07

Beta:

screenshot from 2016-01-23 16 23 29

I've noticed a few other differences between DuckPAN and Beta - such as the Send feedback button.

moollaza commented 8 years ago

@mintsoft @Jedidiah most of this has been fixed with the recent CSS changes on the main site. The i still appears in the bottom left. I believe the fix is to solve #310 -- ensure the CSS order matches the main site.