search

duckduckgo / p5-app-duckpan

DuckDuckHack OpenSource Development Application
http://metacpan.org/module/App::DuckPAN
Other
53 stars 47 forks source link

Feature Request: DuckPAN Package/Code Reloading #52

Closed zekiel closed 9 years ago

zekiel commented 10 years ago

Currently DuckPAN does not listen for changes in the Spice or Goodie packages it has loaded. Adding this ability would greatly benefit developers as they currently are required to restart the DuckPAN Server after making any modifications to .pm files in order for them to take effect.

mwmiller commented 9 years ago

I am currently working on this. I expect something later today.. maybe tomorrow if things go sideways.

moollaza commented 9 years ago

Fixed! Thanks to #196

MrChrisW commented 9 years ago

@moollaza Can we modify this at all not to reload on js or css files? (?i)(js|css)$ https://github.com/duckduckgo/p5-app-duckpan/blob/master/lib/App/DuckPAN/Restart.pm#L95

No need to reload the server for js or css changes? Unless a flush of cache is required?

moollaza commented 9 years ago

@MrChrisW that sounds like a good idea, the CSS/JS gets pulled on refresh, so it might be overkill to restart the process for those.

@zachthompson any thoughts?

zachthompson commented 9 years ago

@moollaza @MrChrisW That would probably be fine. Most files in share don't require a reload, except for the *.txt files.

moollaza commented 9 years ago

@MrChrisW care to submit a PR? or make an issue?

zachthompson commented 9 years ago

@moollaza @MrChrisW See if https://github.com/duckduckgo/p5-app-duckpan/pull/218 does what you expect. There are more than .txt files in /share/ that might require a reload, e.g. .yml. So it just skips js, css, and handlebars files.

moollaza commented 9 years ago

Fixed in #218