search

duckduckgo / p5-app-duckpan

DuckDuckHack OpenSource Development Application
http://metacpan.org/module/App::DuckPAN
Other
53 stars 47 forks source link

Need to be able to skip installing certain dependencies #95

Closed moollaza closed 10 years ago

moollaza commented 10 years ago

Currently there a few IA's which are dependant on native libraries, (e.g. Chinese Zodiac requires libmpfr).

In most cases this is okay, however it creates problems when running duckpan installdeps if either: a) the dependency is broken or has an error you can't get around b) the dependency simply cannot be installed (Codio doesn't allow sudo or apt-get, making it difficult because you would need to manually compile the lib --- ew.) c) you don't want to install a native lib for a Goodie you're not interested in testing

We should be able to skip over dependencies that are unable to be installed, especially the ones that fail because right now I'm unable to finish installing other Goodies' dependencies on Codio (which we're been recommending as the best way to use DuckPAN).

I'm not sure the best approach, but Jag's recent fix to loading the IA Modules by doing so in an eval sounds like one way to handle the dependency installations in DuckPAN.

Any thoughts on this? @jagtalon @russellholt @mwmiller @yegg

mwmiller commented 10 years ago

@moollaza I thought the Codio VM image was a specific DDH version. Wouldn't you be able to update the master image once and see the changes propagate? Or are we concerned here with people who are already using an image which would come unsynced.

I think it's a generally bad idea to encourage disinterest in whether the tests pass for unrelated IAs. That being said, the way they are tested is less than perfect anyway, so it might be fine for now.

Jag's recent fix to loading the IA Modules by doing so in an eval

This seemed to work pretty well for me. I knew pretty quickly what I needed to do to get up-to-date.

moollaza commented 10 years ago

@mwmiller sorry I didn't provide enough context -- basically I thought that the installdeps process was halting on dependency that was unable to be installed. I'm not sure what I was thinking because it wasn't actually doing that, it was just the only dependency I was missing so it looked like it died when that dependency failed.

tldr; there's no issue, you guys can carry on. Sorry!