duckduckgo / privacy-configuration

🎛 Configuration files used by DuckDuckGo's apps and extensions to control which privacy protections are enabled.
Other
105 stars 54 forks source link

Added Duck Player Pip feature #2141

Closed lliverton closed 2 months ago

lliverton commented 2 months ago

Asana Task/Github Issue: https://app.asana.com/0/1205889582400204/1207469433707889/f

Description

Added new Pip feature for Windows currently disabled. It will be enabled at a later date.

Reference

github-actions[bot] commented 2 months ago

Generated file outputs:

legacy
fingerprinting.json (3 more) - fingerprinting.json - protections.json - trackers-unprotected-temporary.txt - trackers-whitelist-temporary.txt ⚠️ File is identical
v1/android-config.json (41 more) - v1/android-config.json - v1/extension-brave-config.json - v1/extension-bravemv3-config.json - v1/extension-chrome-config.json - v1/extension-chromemv3-config.json - v1/extension-config.json - v1/extension-edg-config.json - v1/extension-edge-config.json - v1/extension-edgmv3-config.json - v1/extension-firefox-config.json - v1/extension-safarimv3-config.json - v1/ios-config.json - v1/macos-config.json - v1/windows-config.json - v2/android-config.json - v2/extension-brave-config.json - v2/extension-bravemv3-config.json - v2/extension-chrome-config.json - v2/extension-chromemv3-config.json - v2/extension-config.json - v2/extension-edg-config.json - v2/extension-edge-config.json - v2/extension-edgmv3-config.json - v2/extension-firefox-config.json - v2/extension-safarimv3-config.json - v2/ios-config.json - v2/macos-config.json - v2/windows-config.json - v3/android-config.json - v3/extension-brave-config.json - v3/extension-bravemv3-config.json - v3/extension-chrome-config.json - v3/extension-chromemv3-config.json - v3/extension-config.json - v3/extension-edg-config.json - v3/extension-edge-config.json - v3/extension-edgmv3-config.json - v3/extension-firefox-config.json - v3/extension-safarimv3-config.json - v3/ios-config.json - v3/macos-config.json - v3/windows-config.json ```diff --- v3/windows-config.json +++ v3/windows-config.json @@ -1439,8 +1439,13 @@ "minSupportedVersion": "0.64.0" }, "duckPlayer": { "exceptions": [], + "features": { + "pip": { + "state": "disabled" + } + }, "settings": { "tryDuckPlayerLink": "https://www.youtube.com/watch?v=yKWIA-Pys4c", "overlays": { "youtube": { ```
latest
v4/android-config.json (13 more) - v4/android-config.json - v4/extension-brave-config.json - v4/extension-bravemv3-config.json - v4/extension-chrome-config.json - v4/extension-chromemv3-config.json - v4/extension-config.json - v4/extension-edg-config.json - v4/extension-edge-config.json - v4/extension-edgmv3-config.json - v4/extension-firefox-config.json - v4/extension-safarimv3-config.json - v4/ios-config.json - v4/macos-config.json - v4/windows-config.json ```diff --- v4/windows-config.json +++ v4/windows-config.json @@ -1147,8 +1147,13 @@ "minSupportedVersion": "0.64.0" }, "duckPlayer": { "exceptions": [], + "features": { + "pip": { + "state": "disabled" + } + }, "settings": { "tryDuckPlayerLink": "https://www.youtube.com/watch?v=yKWIA-Pys4c", "overlays": { "youtube": { ```
q71114 commented 2 months ago

Can you consolidate this with https://github.com/duckduckgo/privacy-configuration/pull/2134 and https://github.com/duckduckgo/privacy-configuration/pull/2135?

lliverton commented 2 months ago

Can you consolidate this with #2134 and #2135?

@shakyShane if this PR covers your scenario as well, can you please close those 2 example PRs?

lliverton commented 2 months ago

Hi @q71114 the other 2 example PRs have been closed. Please review again when you get the chance.