duckduckgo / privacy-configuration

🎛 Configuration files used by DuckDuckGo's apps and extensions to control which privacy protections are enabled.
Other
102 stars 55 forks source link

New subfeature for Duck Player with overrides for MacOS and Windows #2175

Closed lliverton closed 4 weeks ago

lliverton commented 1 month ago

Asana Task/Github Issue:https://app.asana.com/0/0/1207677983109067/f

Description

I would like to add autoplay as new sub-feature flag for Duck Player. I updated the overloads for MacOS and Windows.

Reference

github-actions[bot] commented 1 month ago

Generated file outputs:

legacy
fingerprinting.json (3 more) - fingerprinting.json - protections.json - trackers-unprotected-temporary.txt - trackers-whitelist-temporary.txt ⚠️ File is identical
v1/android-config.json (41 more) - v1/android-config.json - v1/extension-brave-config.json - v1/extension-bravemv3-config.json - v1/extension-chrome-config.json - v1/extension-chromemv3-config.json - v1/extension-config.json - v1/extension-edg-config.json - v1/extension-edge-config.json - v1/extension-edgmv3-config.json - v1/extension-firefox-config.json - v1/extension-safarimv3-config.json - v1/ios-config.json - v1/macos-config.json - v1/windows-config.json - v2/android-config.json - v2/extension-brave-config.json - v2/extension-bravemv3-config.json - v2/extension-chrome-config.json - v2/extension-chromemv3-config.json - v2/extension-config.json - v2/extension-edg-config.json - v2/extension-edge-config.json - v2/extension-edgmv3-config.json - v2/extension-firefox-config.json - v2/extension-safarimv3-config.json - v2/ios-config.json - v2/macos-config.json - v2/windows-config.json - v3/android-config.json - v3/extension-brave-config.json - v3/extension-bravemv3-config.json - v3/extension-chrome-config.json - v3/extension-chromemv3-config.json - v3/extension-config.json - v3/extension-edg-config.json - v3/extension-edge-config.json - v3/extension-edgmv3-config.json - v3/extension-firefox-config.json - v3/extension-safarimv3-config.json - v3/ios-config.json - v3/macos-config.json - v3/windows-config.json ```diff --- v3/windows-config.json +++ v3/windows-config.json @@ -1474,8 +1474,11 @@ "exceptions": [], "features": { "pip": { "state": "enabled" + }, + "autoplay": { + "state": "disabled" } }, "settings": { "tryDuckPlayerLink": "https://www.youtube.com/watch?v=yKWIA-Pys4c", ```
latest
v4/android-config.json (13 more) - v4/android-config.json - v4/extension-brave-config.json - v4/extension-bravemv3-config.json - v4/extension-chrome-config.json - v4/extension-chromemv3-config.json - v4/extension-config.json - v4/extension-edg-config.json - v4/extension-edge-config.json - v4/extension-edgmv3-config.json - v4/extension-firefox-config.json - v4/extension-safarimv3-config.json - v4/ios-config.json - v4/macos-config.json - v4/windows-config.json ```diff --- v4/windows-config.json +++ v4/windows-config.json @@ -1175,8 +1175,11 @@ "exceptions": [], "features": { "pip": { "state": "enabled" + }, + "autoplay": { + "state": "disabled" } }, "settings": { "tryDuckPlayerLink": "https://www.youtube.com/watch?v=yKWIA-Pys4c", ```
afterxleep commented 1 month ago

@Bunn do you want to piggyback on this PR to have iOS there too?

Bunn commented 4 weeks ago

@Bunn do you want to piggyback on this PR to have iOS there too?

No preference. The change here is very simple, IMO we can do the iOS one once (if) the iOS settings is implemented.