search

duckduckgo / tracker-radar-collector

🕸 Modular, multithreaded, puppeteer-based crawler
Other
135 stars 48 forks source link

Update autoconsent to 4.1.1, drop Node 12 #87

Closed muodov closed 1 year ago

muodov commented 1 year ago

Breaking change: Node 12 is not supported anymore because puppeteer dropped support last year

muodov commented 1 year ago

@kdzwinel looking at the test failure, could it be related to https://github.com/duckduckgo/privacy-test-pages/pull/114 ?

kdzwinel commented 1 year ago

Per our discussion about keeping 10.2 - we don't want to merge this branch, right? At least not with pptr update?

muodov commented 1 year ago

@kdzwinel yep, I've removed the puppeteer upgrade. In case there's someone watching these changes, it seems like our current usage of raw CDP is incompatible with the latest puppeteer. You can still use --chromium-version to run the tracker-radar-collector with a newer browser version