duckduckgo / zeroclickinfo-fathead

DuckDuckGo Instant Answers based on keyword data files
https://duckduckhack.com/
Other
318 stars 365 forks source link

Can I Use: Add other aliases for CSS filters #171

Closed jagtalon closed 7 years ago

jagtalon commented 8 years ago

It triggers on "can i use css filters" and "can i use css filter effects" but not on "can i use css filter" or "can i use css filter effect"

See https://github.com/duckduckgo/zeroclickinfo-fathead/blob/master/share/fathead/caniuse/output.txt#L370...L372

https://duck.co/ia/view/caniuse

alexnewmannn commented 7 years ago

Hey, I've picked this up. The code should be done, I have a test failing but just reset to master branch and appears it's failing there too, not even sure if the module has tests. It's late now so will be checking this tomorrow and will have a PR then too. 👍

pjhampton commented 7 years ago

Hey @alexnewmannn, sorry for the delayed response. what is the failing test? Is it regarding coverage?

alexnewmannn commented 7 years ago

no worries mate, yeh it is. looks like there isn't any tests for this particular module at all at the minute. On Tue, 7 Feb 2017 at 17:50, PJ Hampton notifications@github.com wrote:

Hey @alexnewmannn https://github.com/alexnewmannn, sorry for the delayed response. what is the failing test? Is it regarding coverage?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/duckduckgo/zeroclickinfo-fathead/issues/171#issuecomment-278082363, or mute the thread https://github.com/notifications/unsubscribe-auth/AFExrwncZ25Qqf_RJZPE7qjwn1BD-fA6ks5raK8CgaJpZM4G7bFM .

pjhampton commented 7 years ago

That's ok, don't worry about the coverage. We can add that at another stage. Push it up and we can review 😄

alexnewmannn commented 7 years ago

Ill try do it tonight, havent been able to get on my personal computer the last week! :)

alexnewmannn commented 7 years ago

@pjhampton there we go https://github.com/duckduckgo/zeroclickinfo-fathead/pull/807, better late than never 😅

pjhampton commented 7 years ago

haha no problem! Thanks so much @alexnewmannn You rock 🤘