search

duckduckgo / zeroclickinfo-fathead

DuckDuckGo Instant Answers based on keyword data files
https://duckduckhack.com/
Other
318 stars 365 forks source link

C++ Reference Docs: Need a new maintainer #402

Closed mylainos closed 7 years ago

mylainos commented 8 years ago

For now I can't anymore be the maintainer of the C++ Reference Docs fathead, so we need a new maintainer !

@duckduckgo/duckduckhack-contributors would anyone out there be interested ?

Here are the pending issues : #301 #300 and #203.

Good luck !

https://duck.co/ia/view/cppreference_doc

sahildua2305 commented 8 years ago

Being Language Leader for C++, I'd love to take over this FatHead. @Mylainos 😄

mylainos commented 8 years ago

Great ! I'd love to see how awesome this FatHead will be ;)

sahildua2305 commented 8 years ago

/cc @moollaza

manrajgrover commented 8 years ago

I would like to take this one too. Since, I've been working on multiple Cheat Sheets, I feel I can improve this too.

mbad0la commented 8 years ago

@sahildua2305 @Mylainos do let me know if you need some more help. I'd love to be of assistance.

sahildua2305 commented 8 years ago

@mbad0la sure! Please have a look at the open issues that @Mylainos mentioned. :smile:

sahildua2305 commented 8 years ago

@ManrajGrover You can improve this fathead without being a maintainer as well 🙂

However, if you want to be a maintainer to give your inputs, go ahead! It's yours. Thanks for being keen! 😄

moollaza commented 8 years ago

I'll give maintainership to @ManrajGrover then 👍

Thanks everyone 🚀

sahildua2305 commented 8 years ago

@Mylainos Can you please do some knowledge transfer about this fathead's implementation?

I had a look at the code and it has no parsing logic in the repo. The entire logic for parsing is in the file downloaded from the reference doc link. Am I missing something?

sahildua2305 commented 7 years ago

@moollaza do you have an idea about this fathead?

mintsoft commented 7 years ago

@sahildua2305 https://github.com/duckduckgo/zeroclickinfo-fathead/blob/master/lib/fathead/c%2B%2B_ref/parse.js#L167

sahildua2305 commented 7 years ago

Oh! I was looking at this.

Thanks @mintsoft 😄

sahildua2305 commented 7 years ago

@mintsoft can you confirm whether this and not the one I mentioned (this) is the one which is live?

amarlearning commented 7 years ago

@sahildua2305 i think this one is not live! As far as I checked there is no IA page for this Fathead.

While on the other hand, this one has it's own IA page

moollaza commented 7 years ago

@sahildua2305 @mintsoft it looks like c++_ref should be removed. The cppreference_doc is the one that should house the code for this IA, because the dir matches the IA Page ID.

sahildua2305 commented 7 years ago

@moollaza However, we have to implement the fathead again then. Because cppreference_doc isn't hosted in our repo and hence not maintainable. What do you think?

moollaza commented 7 years ago

Yes I agree we need to re-implement it. If the original creator is still around (See https://github.com/duckduckgo/zeroclickinfo-fathead/pull/50) then perhaps this can be discussed with him, that we would prefer to maintain the parsing code within our repo moving forward.