Closed hchienjo closed 7 years ago
@hchienjo I want to do this! :grin:
Just go ahead. Thanks @amarlearning for volunteering.
@hchienjo I think the template has a bug! This fathead script works fine!
See this :
There is an extra <br>
that is inserted before Parameters
, because of which we can see an extra line!
It would be great if you tell me where can I find that template so that I can fix it!
Unfortunately we can't edit the template, we'd need to make the parsing script remove the <br>
or the extra line that is produced when the html parser encounters it.
You can refer to the documentation and also join the forum for more instructions and guidance.
You'd need to work on one of these two files: https://github.com/duckduckgo/zeroclickinfo-fathead/blob/master/lib/fathead/sass/parse_functions.py or https://github.com/duckduckgo/zeroclickinfo-fathead/blob/master/lib/fathead/sass/parse_reference.py, test it on codio and then submit a PR.
@hchienjo I'll find a way to do this! Just one more thing, why i am not able to add or remove any labels ?
@amarlearning Thanks for taking this up! I would suggest starting with https://github.com/duckduckgo/zeroclickinfo-fathead/blob/master/lib/fathead/sass/parse_functions.py file as it is the one responsible for parsing information about Sass functions and thus creates the parameter and example headings.
@VeerpalBrar This is strange at first when i looked at the code, I found a <br>
tag due to which a line break was present!
But when i looked into the code today, there wasn't any <br>
tag present! [screenshot]
I think if somehow we can change the css properties of class .prog__container
, we can resolve this issue
@VeerpalBrar As you are the maintainer, let me know what you think ?
@hchienjo @amarlearning This is now fixed, we update the Fathead Database yesterday so that the code blocks have the newlines 👍
Whoops, I thought this was the other issue (#492) . The <br>
may have been from an older version of the output.txt -- The display looks correct to me now 👍
There is an extra newline above 'parameters' subheading as can be seen for example, from here https://duckduckgo.com/?q=sass+opacify&t=lm&ia=about&iax=1
This needs to be removed.
IA Page: http://duck.co/ia/view/sass Maintainer: @VeerpalBrar