duckduckgo / zeroclickinfo-fathead

DuckDuckGo Instant Answers based on keyword data files
https://duckduckhack.com/
Other
318 stars 365 forks source link

jQuery: Add article aliases (redirects) -- $word, $(word), $ word #608

Closed bfmags closed 7 years ago

bfmags commented 7 years ago

Description

We have aliases for $.word, e.g. $.ajax, but we still miss the following ones:

$word - e.g. $ajax $(word) - e.g. $(ajax) $ word - e.g. $ ajax

What to do

For each jquery.* method line in the articles.txt file, create aliases and store them in a new redirects.txt file, in the same directory.

Each line of the redirects.txt file should be structured as follows: alias,original line. E.g: $Callbacks,jQuery.Callbacks()

This change will allow the Instant Answer to trigger for more searches.

Get Started

Resources


IA Page: https://duck.co/ia/view/jquery

amdolan commented 7 years ago

I'll take this. Maybe a few more when I have things running 😄

bfmags commented 7 years ago

@amdolan Thanks! Reach out if you need any help! 👍

amdolan commented 7 years ago

No problem @bfmags, just one question;

in a new redirects.txt file

I'm not sure if this means to clobber the existing file, or if you really want me to append to the file. Clarification would be good 😅

Here's what I did, but I'm second guessing it, I couldn't find how redirects.txt is used..

Edit: Also it looks like I shouldn't have merged to master on my fork, and should have initiated the pull request from my dev branch. Is that correct?

amdolan commented 7 years ago

questions answered here: https://github.com/duckduckgo/zeroclickinfo-fathead/pull/650 will have a pr later on.

bfmags commented 7 years ago

Hi @amdolan is this still going?

pjhampton commented 7 years ago

Hey @bfmags

DuckDuckHack is now in Maintenance Mode and from now on, we are only accepting issues and PRs for essential bugs and bug fixes.

Unfortunately, with the above in mind, this isn't something we can action and will be closed.

We appreciate you taking the time to contribute and apologize for not being able to triage this issue.