duckduckgo / zeroclickinfo-fathead

DuckDuckGo Instant Answers based on keyword data files
https://duckduckhack.com/
Other
318 stars 365 forks source link

CPP Boost: Overtriggering #749

Closed adityatandon007 closed 7 years ago

adityatandon007 commented 7 years ago

Issue Description:

This IA triggers for any query related to things like cpp preprocessor. This happens because boost has a preprocessor title in output.txt which matches but the search is simply regarding cpp preprocessor and not cpp boost preprocessor.

Below is the screenshot

screenshot from 2017-02-07 01-02-51

People to notify

@pjhampton @sahildua2305


IA Page: http://duck.co/ia/view/cpp_boost Maintainer: @nikhilsingh291

pjhampton commented 7 years ago

Space Coverage is less than 1% - https://forum.duckduckhack.com/t/c-boost-fathead/1368 We can remove cpp for now as a trigger and reevaluate the unanswered query data in 2 - 4 weeks. What do you think @sahildua2305?

I guess another option would be giving higher priority to the outgoing cpp_reference

adityatandon007 commented 7 years ago

@pjhampton @sahildua2305 we can remove cpp for now as a trigger but there is one minor change that I would like to bring into your knowledge it should not trigger for cpp but it should trigger for cpp boost when boost cpp is at the end. Currently it triggers only for starting cpp boost triggers but not ending. Here are the screenshots screenshot from 2017-02-07 01-45-42 screenshot from 2017-02-07 01-52-35

moollaza commented 7 years ago

Currently it triggers only for starting cpp boost triggers but not ending.

This is due to a known, internal bug -- we don't have a fix for it right now though.

adityatandon007 commented 7 years ago

@moollaza So, should I close this issue for now.

sahildua2305 commented 7 years ago

@moollaza @adityatandon007 does it trigger when keyword is in the middle of the query? For example, for this query - cpp boost ref if we remove cpp from the trigger?

adityatandon007 commented 7 years ago

@sahildua2305 it does trigger for boost ref (after removing cpp from the trigger). I think something was recently added to the triggrer_words.txt file. This is what I have mentioned earlier that there is something generic going on with this IA and we should avoid generic triggering and therefore I created this issue in the first place.

adityatandon007 commented 7 years ago

@sahildua2305 I think @moollaza recently added this boost in the trigger_words.txt if I remember it correctly and I think it became now more inconsistent. let me see if I can find it in the history.

adityatandon007 commented 7 years ago

yeah @sahildua2305 I found it and I was correct. here is the link: https://github.com/duckduckgo/zeroclickinfo-fathead/commits/master/lib/fathead/cpp_boost/trigger_words.txt

adityatandon007 commented 7 years ago

@sahildua2305 I also think that we should remove this boost trigger because boost and anything related to title of that output.txt file can trigger this IA which user might not want to see. Like he might type "boost spirit" and he want to see the answer regarding how to boost spirit but instead he would see this IA result which we didn't want in the first place. screenshot from 2017-02-14 04-06-44

sahildua2305 commented 7 years ago

I also think that we should remove this boost trigger

I agree

adityatandon007 commented 7 years ago

I will make the changes and then let you know

On Feb 16, 2017 1:44 AM, "Sahil Dua" notifications@github.com wrote:

I also think that we should remove this boost trigger

I agree

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/duckduckgo/zeroclickinfo-fathead/issues/749#issuecomment-280125625, or mute the thread https://github.com/notifications/unsubscribe-auth/AX8foUtprlN8pj5IppW2qNL9kq-v9Zdoks5rc1y_gaJpZM4L4oye .

adityatandon007 commented 7 years ago

@sahildua2305 I have updated the triggers. I have also removed the cpp trigger too avoid the clashes with cpp reference fathead. If you suggest it's not right then I can add that in the trigger_words.txt file.

adityatandon007 commented 7 years ago

@sahildua2305 Please review