Closed abeyang closed 9 years ago
Hey @abeyang I'm lost now. I think too many files are in my repo since I added some pngs because I couldn't get them to disappear.
I also took out this style:
.zci--cheat_sheets .cheatsheet__footer hr {
color: rgba(0,0,0,.15);
}
I couldn't find any reference to it in the detail.handlebars
file in the footer:
<div class="cheatsheet__footer c-list__links">
<a class="c-list__link chomp--link sep--after can-expand">
<i class="chomp--link__icn"></i>
<span class="chomp--link__mr">Show More</span>
<span class="chomp--link__ls">Show Less</span>
</a>
<span>{{{moreAt metadata 'none' className="c-list__link"}}}</span>
</div>
This is the screenshot of the finished updates:
Let me know if I need to change something in my repo to get that pulled correctly!
Sweet! We'll review this shortly, and get back to ya!
@moollaza can we get this on a dev machine?
@spentacular awesome! Can you please make a PR? We can continue the discussion and further changes in there :+1:
Hey, I think I poorly referenced this here, and saw it in the Weekly Update email, and just wanted to see if there was any updates on the dark styles. Thanks!
Fixed in #1312
Cheatsheets need some visual touches / css love.
First, update the headings:
Let's tweak the paddings to the keys, just a bit:
--and align the baseline of the description to the keys:
After, let's create some greater separation between the rows:
Finally, let's get rid of the border-line in the footer: Under
.zci--cheat_sheets .cheatsheet__footer
, please remove theborder-top
property completely.In the end, should look something like this:
Thanks!