Eclipse IDE Cheat Sheet: It's throwing a JS Error

[bsstoner]

---

IA Page: http://duck.co/ia/view/eclipse_cheat_sheet

[moollaza]

@bsstoner I'm unable to re-create this, but I don't think anything has changed. All the cheatsheets run the same JS so if there's a bug, we should see it for all Cheat Sheets.

Are you still able to produce this?

[preemeijer]

I also tried it right now and I also can't reproduce the error...

[mintsoft]

@bsstoner @moollaza I've just reproduced it here: on Vivaldi 1.0.291.18 (Developer Build) (32-bit) windows; although I doubt that's significant:

[mintsoft]

@bsstoner @moollaza now I've expanded it I think it's that this is commented out and the JSON contains */:

[moollaza]

@mintsoft great find! I've confirmed this as well. It only happens in Chrome for me. Firefox seems to be OK. The problem is that our commented out script tag is being in-commented by the */ characters in the Cheat Sheets JSON.

@bsstoner I'd say this is an internal (or browser) bug? Is there a reason we have that script tag commented out like that?

[mintsoft]

@moollaza I think the problem is basically "javascript comment injection", it looks like to me like the script tag on the page is commenting out the content of the JSON (for some reason) and https://github.com/duckduckgo/zeroclickinfo-goodies/blob/master/share/goodie/cheat_sheets/json/eclipse.json#L388 isuncommenting it?

That is to say, I don't think it's a browser bug, I think we're doing a weird thing!

[moollaza]

That is to say, I don't think it's a browser bug, I think we're doing a weird thing!

@mintsoft what's odd though is that Firefox seems to ignore the */ in the JSON. I'm not sure if that's Firefox making a mistake, or being clever. I didn't check Safari yet though...

[moollaza]

Yup, breaks in Safari as well.

[mintsoft]

@moollaza hmm yeah, I guess it feels a little like it's a bug in Firefox to me! I don't see why it wouldn't break

[tagawa]

Closing, as it looks like @Mailkov's PR fixed this.