search

duckduckgo / zeroclickinfo-goodies

DuckDuckGo Instant Answers based on Perl & JavaScript
https://duckduckhack.com/
Other
980 stars 1.76k forks source link

Solar System: show in different unit of measure? #3870

Closed bsstoner closed 2 years ago

bsstoner commented 7 years ago

User Feedback: Should be in SI units and not in "lbs". Come on get serious it's 2017 now. When I'm looking for the mass of the Earth the last thing I want to know is the number in disgusting imperial units.

IA Page: http://duck.co/ia/view/solar_system Maintainer: @MrChrisW

bsstoner commented 7 years ago

Another one: lbs is not a unit of mass. Slugs or Kilograms are.

MrChrisW commented 7 years ago

@bsstoner I'll take this. The USA is reason we show imperial units, it was discussed in the original MR 😃

bsstoner commented 7 years ago

We could tie it to the Unit of Measure setting? https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/share/spice/forecast/forecast.js#L350

MrChrisW commented 7 years ago

@bsstoner sure, would we default to SI units (metric) if there's no preference?

bsstoner commented 7 years ago

yea, that's the problem with that setting, it defaults to USA which probably won't solve the problem for most people...

We could use their locale and just show lbs for US and metric for everyone else? https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/lib/DDG/Spice/Currency.pm#L119

MrChrisW commented 7 years ago

@bsstoner that's what we do currently 😕 https://github.com/duckduckgo/zeroclickinfo-goodies/blob/master/lib/DDG/Goodie/SolarSystem.pm#L51-L58

bsstoner commented 7 years ago

lol, doh!

MrChrisW commented 7 years ago

related issue https://github.com/duckduckgo/zeroclickinfo-goodies/issues/2116

bsstoner commented 7 years ago

Oh interesting, I didn't realize you were already discussing this. Linking to the unit of measure setting makes sense.

FWIW Google, Wikipedia, Wolfram Alpha all use kg (even for me in the US). We could maybe just drop lbs and show kgs to everyone?

bsstoner commented 7 years ago

We've gotten some more feedback on this: "Most people searching for Mars' radius will be doing so for scientific purposes and thus SI units should be used."

I would say just switch to kgs everywhere? We can see if there's any backlash and re-adjust if so?

mintsoft commented 7 years ago

I would say just switch to kgs everywhere? We can see if there's any backlash and re-adjust if so?

Absolutely! Only damn American's use silly units like lbs!