Closed nfriedly closed 10 years ago
Hi @nfriedly
Raising GitHub Issues is probably the best way to provide feedback about a specific goodie as there're more people (DDG Staff as well as community leaders) who can take a look at it.
Looking at your actual problem, it's worth noting that the FedEx track system works with both (https://www.fedex.com/fedextrack/?tracknumbers=882227378545377 https://www.fedex.com/fedextrack/?tracknumbers=9612804882227378545377 ). Do you know if the leading 9612804 has some significance or is stylised in some way, (9612804-882227378545377) perhaps?
Thanks,
I don't think so, it was in an email from an IKEA order:
(FWIW, the IKEA website was having issues, so I placed that order over the phone.)
Interesting, it looks like the issue is within the FedEx goodie not supporting 22 digit numbers within the checksum somehow. I've had a quick glance and compared it to the spec (http://images.fedex.com/us/solutions/ppe/FedEx_Ground_Label_Layout_Specification.pdf) but I can't immediately see what's going on. I think @jagtalon wrote this originally and can shine some light on it.
It looks like adding "fedex" (https://duckduckgo.com/?q=9612804882227378545377+fedex) works but it doesn't without it. Definitely a bug. :) I'll take a look into it.
@mintsoft The regexp is a bit hairy, so it might need a bit of cleanup haha.
What happens if two different zero-clicks get triggered? Because I think some of the USPS numbers are similar (If you change the second digit from 6 to 2, it triggers the USPS zeroclick)
@nfriedly the actual triggers (i.e. the regex) can overlap without an issue as long as the goodie itself handles it correctly. Assuming that both USPS and FedEx use a checksumming mechanism that is bug free (no guarantees!) and non-overlapping then they should work it out correctly. Judging by what @jagtalon said, I'd assume the issue is that the correct goodie is triggering, but the matches from the regex are leading it down the wrong checksumming path
@nfriedly I've just submitted a PR that appears to solve this issue; hopefully should be merged/deployed soon.
Thanks to @mintsoft, this has been fixed. :cake:
Awesome, nice work!
I too have received a Ground with dual tracking numbers, 15 and 7 + 15 digits. The first seven are 9612422. We nearly lost the package because the vendor and our shipping/receiving office do not recognize 22 digit numbers.
Were this a Smart Post package, I have read that the coding would be "92" + 20 digits.
Are there clues in the community as to what 96, 9612 (quoted earlier in this thread), or the full first seven digit prefix indicate?
@ledatelescope It's been a while since I looked at the spec however I think page 8 of http://images.fedex.com/us/solutions/ppe/FedEx_Ground_Label_Layout_Specification.pdf should explain the significance of the characters
Spot on. I had missed that when scanning the doc. Thank you very much.
On 8/25/17 17:22, Rob Emery wrote:
@ledatelescope https://github.com/ledatelescope It's been a while since I looked at the spec however I think page 8 of http://images.fedex.com/us/solutions/ppe/FedEx_Ground_Label_Layout_Specification.pdf should explain the significance of the characters
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/duckduckgo/zeroclickinfo-goodies/issues/393#issuecomment-325037394, or mute the thread https://github.com/notifications/unsubscribe-auth/AJfeMkEBJ1NLGAFVTBxD-3aLc2sOckq0ks5sbzsdgaJpZM4B4EO-.
-- Lincoln J. Greenhill Harvard-Smithsonian CfA Office: 1 617-495-7194 60 Garden St, Mail Stop 42 Cell: 1 650 722-7798 Cambridge, MA 02138 FAX: 1 617-495-7345 greenhill@cfa.harvard.edu Skype: ljgreenhill www.cfa.harvard.edu/~lincoln
No problem, happy to help @ledatelescope
I emailed about this one a little bit ago, but then it occurred to me that I might as well try and report it the right way also ;)
This FedEx tracking number doesn't get recognized by DDG: https://duckduckgo.com/?q=9612804882227378545377
If you trim off the first part, so it's only 15 digits, it does get picked up: https://duckduckgo.com/?q=882227378545377
I took a look at the code, but I'm not too familiar with FedEx numbers, so I'm not (yet) sure what the fix is. I'll send a pull request if I do figure it out though.