HTML Entities encoding should use already existing functions

duckduckgo / zeroclickinfo-goodies

DuckDuckGo Instant Answers based on Perl & JavaScript

https://duckduckhack.com/

Other

979 stars 1.76k forks source link

Closed mintsoft closed 10 years ago

mintsoft commented 10 years ago

Usages of use HTML::Entities qw(encode_entities);should be replaced with html_enc() which already exists within a goodie

mintsoft commented 10 years ago

For the record, I think most of these I've put in! the list seems to be:

mwmiller commented 10 years ago

Also worth noting, I tried a simple replace and the semantics/outputs of html_enc are slightly different, so this requires some care to complete.

moollaza commented 10 years ago

@mintsoft @mwmiller the updates to html_enc have been merged so hopefully things should be much easier now :)

mwmiller commented 10 years ago

@moollaza Cool. When will that make it to DuckPAN so we can do the conversion without breaking tests?

moollaza commented 10 years ago

@mwmiller I'll release DDG now and then it should be live :)

mintsoft commented 10 years ago