duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Timer: Doesn't work correctly with non-qwerty keyboards #1017

Closed mintsoft closed 10 years ago

mintsoft commented 10 years ago

This is pretty niche, however it looks like https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/share/spice/timer/timer.js#L213 doesn't work with alternative keyboard layouts; I'd guess that the VKcodes are different.

Based on: https://duck.co/ideas/idea/4408/q-timer-bug

cc @moollaza @mattr555

mattr555 commented 10 years ago

We could just get rid of it and use the numericOnly() function there. It creates a "backspace effect" (that is, when you type, you see the letter briefly and then it goes away), but if the other way makes it unusable for people, then it might be an ok compromise.

mwmiller commented 10 years ago

it might be an ok compromise

Sounds OK to my ear.

mintsoft commented 10 years ago

Yeah sounds cool to me