search

duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Movie spice doesn't check for undefined release date #141

Closed moollaza closed 11 years ago

moollaza commented 11 years ago

Eg. https://duckduckgo.com/?q=movie+test

Noticed that the release date for this movie comes through as "(undefined)". This should be fixed.

moollaza commented 11 years ago

Also, "Unrated" is capitalized when it probably shouldn't be.

jagtalon commented 11 years ago

@moollaza I think I fixed that in https://github.com/duckduckgo/zeroclickinfo-spice/commit/dc7cce5620fd378fb1fa56862f2cf6ab02016540, https://github.com/duckduckgo/zeroclickinfo-spice/commit/3b331520f36bf5dea8f69f2184b03c47888aa965, and https://github.com/duckduckgo/zeroclickinfo-spice/commit/2e7b907253c9e1a5d8f219b3c08860662d95a0de

I have to check, though, just to be sure. These will be merged with master soon.

Thanks!

jagtalon commented 11 years ago

@moollaza Yup, fixed it: https://jagtalon.duckduckgo.com/?q=movie+test. And "Unrated" is capitalized in the API. Should it not be when displayed?

Selection_010

Edit: Yes, it shouldn't be.

jagtalon commented 11 years ago

https://github.com/duckduckgo/zeroclickinfo-spice/commit/07a52314ba48170f3344eeb770c1a4383d1a933f

moollaza commented 11 years ago

@jagtalon no I think we should remove the capitalization because its used mid-sentence and isn't a proper name etc, so it really shouldn't be capitalized.

jagtalon commented 11 years ago

@moollaza voila! https://jagtalon.duckduckgo.com/?q=movie+test