Remove IE 7 in the PR template?

duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs

https://duckduckhack.com/

Other

548 stars 942 forks source link

Closed jagtalon closed 9 years ago

jagtalon commented 9 years ago

Running DuckPAN server and viewing it on IE 8 doesn't even work because we have console.log in there. Should we even list it?

I don't think we should because people won't be able to test it on IE 8 and below at all. What do you think, @moollaza?

MrChrisW commented 9 years ago

@jagtalon IE8 It does work, it just looks bad ____ selection_173

jagtalon commented 9 years ago

@MrChrisW oh it does! Well, I guess just IE 7 then since we don't even support it in production (well, we do, but it goes to the lite site):

screen shot 2015-02-06 at 10 16 34 am

MrChrisW commented 9 years ago

@jagtalon :+1: down with IE 7!

moollaza commented 9 years ago

Makes sense to me!

javathunderman commented 9 years ago

Made a PR. Feel free to take a look.

jagtalon commented 9 years ago

Fixed by @javathunderman in #1526

javathunderman commented 9 years ago

@jagtalon :+1:

javathunderman commented 9 years ago

@jagtalon Should we remove the test requirement in the pull request template for the other repositories (goodies, fathead, etc.)?