search

duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Finish Up the Colour Picker IA #1495

Closed moollaza closed 9 years ago

moollaza commented 9 years ago

The PR has been abandoned by the original contributor, but our design team has posted an amazing mockup of how it should look.

https://github.com/duckduckgo/zeroclickinfo-spice/pull/1351

Any takers?

/cc @mattr555 -- I thought you might be interested

mattr555 commented 9 years ago

Hi @moollaza, I pulled the code to take a look and the image assets didn't load on duckpan. Instead I got a 500: http://sprunge.us/fFVB

Known bug?

Edit: I fixed this by moving the image files out of assets/, I guess DuckPAN can't handle subdirectories?

MrChrisW commented 9 years ago

@mattr555 Just as a reference there's an issue lodged on p5-app-duckpan #136.

moollaza commented 9 years ago

Edit: I fixed this by moving the image files out of assets/, I guess DuckPAN can't handle subdirectories?

@mattr555 I'm glad you were able to find a workaround! Yes it's a known bug as of a couple weeks ago. When I get a chance I'll take a look but for now I guess we should just avoid using sub-directories.

moollaza commented 9 years ago

@mattr555 fixed this in a duckpan PR (https://github.com/duckduckgo/p5-app-duckpan/pull/230), feel free to test out the updated duckpan code :)