duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
549 stars 942 forks source link

Revive Old IA Branches #1535

Closed moollaza closed 7 years ago

moollaza commented 9 years ago

https://github.com/duckduckgo/zeroclickinfo-spice/branches/stale

Previously we have pushed the "abandoned" PRs to a branch for others to work off of and they've been sitting there for a while now untouched.

Most of the branchs here have Spice IAs that are nearly complete, but in many cases need to be updated to meet the current Spcie practices (using built-in Templates and the new Spice API)

If you're interested in picking up some of these IA's feel free to let us know and submit a PR :smile:

tagawa commented 9 years ago

Re. the exoplanets IA, the original API (exoapi.com) seems dead but NASA have a public API that could probably be used: http://exoplanetarchive.ipac.caltech.edu/docs/program_interfaces.html

iambibhas commented 9 years ago

I looked at the ideas/firefox-plugins branch. addons.mozilla.org API now returns XML as mentioned here. They probably changed it since the last time that branch was used.

moollaza commented 9 years ago

@iambibhas it looks like that branch was going to use XML (which isn't allowed), but I just tried adding ?format=json to an example URL in their docs and it worked! :smiley:

https://services.addons.mozilla.org/en-US/firefox/api/1.5/addon/1865?format=json

Update: Damn, that's not a search query. The Search Endpoint returns a "not implemented" -- https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/popup?format=json?

Looks like we'll have to forgo this IA for now :disappointed:

iambibhas commented 9 years ago

Cool! Not sure why it isn't documented. So I Can work on it. Lemme give it a try.

iambibhas commented 9 years ago

Looks like JSON response isn't available for the search endpoint.

{
    "msg": "Not implemented yet."
}

https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/memory/all/1?format=json

iambibhas commented 9 years ago

This old IA(stale branch upc) specifies the API Key in plain text. That should be removed, right? https://github.com/duckduckgo/zeroclickinfo-spice/blob/upc/lib/DDG/Spice/Upc.pm#L10

moollaza commented 9 years ago

@iambibhas that's not one of DDG's keys, it's the contributor's, but yes if you plan to bring back that IA, you should get a new key, and replace it with our standard syntax: {ENV{{DDG_SPICE_UPC_API_KEY}}}.

The contributor isn't using that key though for anything else. He was a DDG intern :)

iambibhas commented 9 years ago

Just maintaining a checklist -

javathunderman commented 9 years ago

@moollaza I'll make a PR for lobbying (with unchanged code) and I think we can go from there.

iambibhas commented 9 years ago

@mariano-simone-zocdoc I agree that it's really poor. I tried finding a better source, but couldn't find anything. Might need a vote to decide what to do with it.

altern8tif commented 9 years ago

@mariano-simone-zocdoc @iambibhas Found this from Digit-Eyes. It has thumbnails and a link to the product page. Unfortunately it's not free.

Not sure what DDG's policy on APIs which require paid access though. Couldn't find it in the documentation.