search

duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Currency: Support "X pounds in dollars" #1883

Closed mintsoft closed 9 years ago

mintsoft commented 9 years ago

Moved from: https://github.com/duckduckgo/zeroclickinfo-goodies/issues/1170

Got a note on twitter that we're not converting in the form X pounds in dollars https://twitter.com/vectorvitale/status/605771245599064064/photo/1

https://duck.co/ia/view/currency

jagtalon commented 9 years ago

Maybe we can add it as an alias to GBP

domjacks commented 9 years ago

The issue with this is that not only the United Kingdom uses the term 'pound'. There's the Egyptian pound, Syrian pound etc. http://en.m.wikipedia.org/wiki/Pound_(currency)#Countries_currently_using_the_pound_or_similar

Hence why the aliases in the currency/currencyNames.txt file that include 'pound' have the nation in front of them.

moollaza commented 9 years ago

I think it's OK to assume "pound" means GBP, given that it's the most popular "pound". We handle "dollars" similarly and use USD.

Similarly, Bing, Yahoo, and Google make the same assumptions, so I think it's fair to maintain that, as it's likely the user's expectation.

domjacks commented 9 years ago

I've created a PR which just adds 'pounds' as an alias here:

https://github.com/duckduckgo/zeroclickinfo-spice/pull/1907

moollaza commented 9 years ago

@domjacko thanks!