duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 943 forks source link

Pokedex - need better "more at" url #1969

Closed iambibhas closed 9 years ago

iambibhas commented 9 years ago

Right now the "more at pokeapi.co" links pokeapi.co, without any permanent url for the specific pokemon. That page just shows how to call the api. It's kind of useless. We could probably link it to bulbapedia.

Also, the name of the pokemon being searched is linked to that search page itself. E.g. searching for Machop hyperlinks the name Machop to https://duckduckgo.com/?q=pokemon+machop&t=canonical&ia=pokedex&iax=1. We could avoid doing that. It's no help at all. Linking the pokemon they evolve to, to the duckduckgo search page is fine.

/cc @AkA84

moollaza commented 9 years ago

@iambibhas I agree on a better "More at" link. We should use the new moreText property to give credit to the data source as well, like we do for the Stocks IA: https://duckduckgo.com/?q=appl+stock&ia=stock

gokul1794 commented 9 years ago

We can use the official link http://www.pokemon.com/us/pokedex/ Is anyone working on it yet?

MrChrisW commented 9 years ago

@gokul1794 No one has taken this up yet.

Looks like we could easily do sourceUrl: 'http://www.pokemon.com/us/pokedex/<pokemon name>'

However we'd need to check if this is allowed? @moollaza

iambibhas commented 9 years ago

Bulbapedia has more data than the official pokemon site and less resource hungry, it's also the go-to website for any kind of info on pokemons. We could probably mention both. I think if it's helping the user who's searching, it should be allowed.

AkA84 commented 9 years ago

@iambibhas sorry for not having been able to look at this! @moollaza I noticed that I'm not credited on the IA info, how can I change that? Thanks!

moollaza commented 8 years ago

I noticed that I'm not credited on the IA info, how can I change that? Thanks!

@AkA84 apologies! I will fix that right now. Do you have a duck.co account?

Update: Should be fixed. For now it's linked to your GitHub, but if you create a duck.co acct I can link to that instead.