search

duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Guidebox instant answer showing Season 0 Ep. 0 #200

Closed zekiel closed 11 years ago

zekiel commented 11 years ago

E.g. https://duckduckgo.com/?q=watch+dragonballz

moollaza commented 11 years ago

Looks like the problem is with the API, the season/episode from the API is actually 0 for both. @guidebox is there anything you can do about that?

jeremyriney commented 11 years ago

If there isn't any episode or season # available, it will show 0. Those first several episodes are specials and thus season # is 0. They should have had an episode # so now they do and will update when the cache clears.

You should probably not show the season / episode information if it is 0. Some simply don't have season or episode information. For example, 60 minutes isn't assigned Season / Episode information so they will always show 0. You can in these cases simply hide the season / episode line completely.

https://duckduckgo.com/?q=watch+60+minutes

moollaza commented 11 years ago

@guidebox thanks for explaining!

@jagtalon please fix accordingly :)

jagtalon commented 11 years ago

@moollaza @zekiel @guidebox Thanks, guys. I'll make the fix. :)

Also, I just found this when I clicked on the "60 minutes" query: screen shot 2013-09-11 at 5 31 16 pm

I'll put this on another issue.

jeremyriney commented 11 years ago

That looks like an API issue. Once I fix that it will be fixed on your end.

From: Jag Talon notifications@github.com Reply-To: duckduckgo/zeroclickinfo-spice <reply+i-19154171-1b295be7d822808a42cfbe817f0c3c082f4a3fb6-4379343@reply.git hub.com> Date: Wed, 11 Sep 2013 14:33:20 -0700 To: duckduckgo/zeroclickinfo-spice zeroclickinfo-spice@noreply.github.com Cc: guidebox api@guidebox.com Subject: Re: [zeroclickinfo-spice] Guidebox instant answer showing Season 0 Ep. 0 (#200)

@moollaza https://github.com/moollaza @zekiel https://github.com/zekiel @guidebox https://github.com/guidebox Thanks, guys. I'll make the fix. :)

Also, I just found this when I clicked on the "60 minutes" query: https://f.cloud.github.com/assets/81969/1126793/bcb62dfe-1b29-11e3-8240-11 44c8e3f198.png

I'll put this on another issue.

‹ Reply to this email directly or view it on GitHub https://github.com/duckduckgo/zeroclickinfo-spice/issues/200#issuecomment-2 4278195 .