duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Public Holidays: Merge duplicate date/events #2594

Closed MrChrisW closed 8 years ago

MrChrisW commented 8 years ago

Events on the public holidays IA are repeated several times when the only change in data is the region.

This is due to the API returning the same event with a new id and new "states" - api response. Maybe we can merge these events into a single item on the table?

Examples:

https://beta.duckduckgo.com/?q=public+holidays+in+united+states&ia=answer&iax=1

2016-03-17-32-public holidays in united states at duckduckgo

https://duckduckgo.com/?q=public+holidays+in+australia

2016-03-17-38-public holidays in australia 2400 at duckduckgo


IA Page: http://duck.co/ia/view/public_holidays Maintainer: @sekhavati

moollaza commented 8 years ago

@MrChrisW good catch! -- For some reason I don't see Cesar Chavez day at all for the first link. However with the recent updates to this IA (adding local holidays) I see duplication in the results:

https://beta.duckduckgo.com/?q=public+holidays+in+united+states&ia=answer&iax=1

MrChrisW commented 8 years ago

@moollaza

For some reason I don't see Cesar Chavez day at all for the first link.

Yup, I was testing it out on BETA! :wink:

sekhavati commented 8 years ago

@MrChrisW Thanks for pointing this out. Please assign this issue to me and I'll fix it. Looks like the API is returning multiple objects for the same holiday with a differing set of states. Each have the same id though so I think it should be fairly straight forward to fix this.

MrChrisW commented 8 years ago

@sekhavati Thanks for the quick fix. It's great to see the holidays IA continually improving! :+1: