duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Dictionary: "define fungi" shows two play buttons #2609

Closed jagtalon closed 8 years ago

jagtalon commented 8 years ago

And they're in the subtitle--it should be right beside the title.

https://duckduckgo.com/?q=define+fungi&ia=definition screen shot 2016-03-21 at 9 58 58 am


https://duck.co/ia/view/dictionary_definition Maintainer: @jagtalon

moollaza commented 8 years ago

Hey @duckduckgo/duckduckhack-active-contributors! Anyone interested in fixing this issue?

If so, comment here to let us know and we'll assign the task to you so everyone knows what's going on.

It'll require a bit of JS knowledge. We had made some changes the the DDG Playbutton for the Forvo Spice and I think this IA will need some adjustments as a result.

A good place to start looking is here: https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/share/spice/dictionary/definition/dictionary_definition.js#L187

marianosimone commented 8 years ago

@moollaza: I'd love to take a look. However, it seems like in my dev environment only 1 play button is shown (working from codio, with latest duckpan installed)

moollaza commented 8 years ago

@marianosimone it looks like we're making a secondary API call in production for fungus. We should probably add a check that if a player exists on the page, we shouldn't add another?

tagawa commented 8 years ago

Fixed internally.