search

duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Timer: continues to wiggle after alarm sound has been dismissed #2625

Closed thistleBgood closed 8 years ago

thistleBgood commented 8 years ago

Had multiple instant answer timers open at once, only one counting down. When it ran out, it did the usual notification of making a trilling sound and wiggling back and forth. I think I clicked somewhere in the instant answers area, somewhere within the red box shown on the attached image. When I did so, the sound stopped and it reverted to the display shown in the picture, but it continued wiggling back and forth. Eventually I clicked somewhere else and it stopped, but that was after several minutes of it wiggling.

screenshot from 2016-03-26 18 50 18

Issue occurred on the following platform: Chromium Version 49.0.2623.87 Ubuntu 14.04 (64-bit)

IA Page: http://duck.co/ia/view/timer Maintainer: @mattr555

GuiltyDolphin commented 8 years ago

@thistleBgood I noticed this once when adding a countdown to the tab name... Never saw it happen since. Have you managed to reproduce the behavior?

thistleBgood commented 8 years ago

Unfortunately not. I was surprised to encounter it, and wasn't paying attention to where I was clicking, hence the imprecise boundaries of the box in the screenshot. I tried to get it to work with other timers in other tabs but they behaved properly every time I did.

GuiltyDolphin commented 8 years ago

@thistleBgood Hmm... Are you at all versed in JS? If so, the appropriate code (I believe) is the shake function. I'll have a peer myself and let you know if I spot anything weird.

moollaza commented 8 years ago

@thistleBgood @GuiltyDolphin It looks like clicking outside the tile stops the animation but doesn't reset the tile from the "completed" state (green checkmark).

Definitely an issue around the click handler

mattr555 commented 8 years ago

Definitely hard to track this one down! I'll try to fix this one and another bug I found (timer starts automatically if you close all timers and open another, with a specified time in the query) early next week.

mattr555 commented 8 years ago

@thistleBgood @GuiltyDolphin sorry, I still can't reproduce this. The idea is to stop the sound and shaking when there is a click on the screen, but keep the checkmark until the user explicitly clicks on that. If this bug is rare can we tolerate it?

GuiltyDolphin commented 8 years ago

@mattr555 My DuckPAN is being a bit off lately and I can't reproduce it on production.

I'm happy to have it Tolerated - at least for now (it isn't a huge issue); if we get more reports we can look into it further - my guess is it might be managing to click at the same time as a loop starts/stops? Something difficult to do.

@thistleBGood Thanks for bringing this up! I'll let you know if this gets fixed in a future revision.

edgesince84 commented 8 years ago

I'm also unable to reproduce this issue, so I'm going to close it out for now. If anyone can reproduce it, feel free to open it back up. thanks!