search

duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Quote Of The Day: Quote icon cut off on mobile devices #2758

Closed moollaza closed 8 years ago

moollaza commented 8 years ago

On mobile devices the quote icon is clipped making it look broken.

We should fix or remove the icon on smaller screens

IA Page: http://duck.co/ia/view/quote_of_the_day Maintainer: @pnpninja

NaveenKarippai commented 8 years ago

@moollaza I'm interested to pick up this issue. Could you please assign it to me.

moollaza commented 8 years ago

@NaveenKarippai thanks, assigned!

NaveenKarippai commented 8 years ago

@moollaza Please review PR https://github.com/duckduckgo/zeroclickinfo-spice/pull/2781

UPDATE: The design layout seems to work fine when the quote (spice output) is small or medium in word length. The design layout breaks for author (attribution) on large screen devices.

The tricky part could be getting the word length and applying CSS style. Could you please check the same. Thanks!

pnpninja commented 8 years ago

Thanks @NaveenKarippai

edgesince84 commented 8 years ago

Hey @pnpninja, good to see you around these parts again! Anything new you're thinking of working on?

pnpninja commented 8 years ago

Hey there @edgesince1984. I'll try picking up some issues and new features from the list online.. We could extend the quote of the day spice - https://theysaidso.com/api/#qodcat

Showing the quote based on categories

pnpninja commented 8 years ago

Hey there @edgesince84. I'll try picking up some issues and new features from the list online.. We could extend the quote of the day spice - https://theysaidso.com/api/#qodcat

Showing the quote based on categories

edgesince84 commented 8 years ago

@pnpninja sounds good!

pnpninja commented 8 years ago

Can we close this issue?