search

duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Time: Overtriggering on 'month' #2870

Closed GuiltyDolphin closed 7 years ago

GuiltyDolphin commented 8 years ago

If I use the query "month", it triggers this Instant Answer. Is this expected behavior? I feel it is overtriggering somewhat.

"week" triggers an entirely separate Instant Answer (perhaps one that could handle the query of "month"?).

IA Page: http://duck.co/ia/view/time Maintainer: @MrChrisW

edgesince84 commented 8 years ago

"month" does tell you the month, but not the same way "week" breaks it down ie "We are in the __th week of the year."

MrChrisW commented 8 years ago

Related https://github.com/duckduckgo/zeroclickinfo-spice/issues/2946

This was added in https://github.com/duckduckgo/zeroclickinfo-spice/pull/2524 - Looking at the tests it may have only been intended to trigger on what\'s the month in <city> not just the month. @Sayanc93 can you look into this?

mrshu commented 7 years ago

As far as I can see, month no longer triggers the Time Spice and this issue can therefore be closed.

moollaza commented 7 years ago

Priority has been given to the conversions Instant Answer now