search

duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Cryptocurrency Bug: triggers not working #3036

Closed kewde closed 7 years ago

kewde commented 7 years ago

Type of Issue

The cryptocurrency IA is not being triggered, ever. The triggering had issues before when I did a little work on it, but it somehow magically went back to working. Now, it's completely broken. As a point of reference: https://github.com/duckduckgo/zeroclickinfo-spice/commits/master/share/spice/cryptocurrency/cryptocurrencylist.txt It got bricked after my commits.

Steps to recreate

1 btc to ltc 10 ltc to btc 20 sdc 10 sdc to btc

@claytonspinner

IA Page: https://duck.co/ia/view/cryptocurrency

claytonspinner commented 7 years ago

hm, not sure what would cause this to stop triggering. It works for me in the DuckDuckHack environment. I'll keep looking into it. @MrChrisW and @moollaza do you know what might cause this to work in the Codio dev environment but stop working in production?

stormwindy commented 7 years ago

I have recreated the situation. However, everything worked well. What I have realized is that, conversion does not trigger while trying to convert 1 sdc to any other currency form. Other conversions worked well (including ltc, btc, XRP). It does not get bricked. It just gives "no results were returned from Instant Answer". Example of a not working trigger 1 sdc to 'any other currency'. @claytonspinner

pjhampton commented 7 years ago

This IA has been knocked offline, see production state: https://duck.co/ia/view/cryptocurrency/json I will put the offline trigger here to notify staff.

pjhampton commented 7 years ago

This has now been fixed 👍