duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Currency: Add "peso" as alias for Mexican Peso #3217

Closed moollaza closed 7 years ago

moollaza commented 7 years ago

Problem

The word peso should exist as an alias for "Mexican Peso" (which seems to be the most popular Peso) in currencyNames.txt.

From user feedback and unanswered query data, we can see that this is something we need.

This issue would be perfect for a newcomer who hasn't yet contributed to DuckDuckHack!

Solution

  1. Add 2 or 3 tests to t/Currency.t
    • e.g. 1 peso to usd
  2. Add the aliases in currencyNames.txt
  3. Verify tests pass by running duckpan test currency
  4. Send Pull Request

People to notify

@pjhampton

Get Started

Resources


Instant Answer Page: https://duck.co/ia/view/currency

mkw2000 commented 7 years ago

I would like to give this a go !

pjhampton commented 7 years ago

Thanks @mkw2000... it's all yours! reach out if you need some help

moollaza commented 7 years ago

@mkw2000 I've invited you to the DDG org, once you accept, we can set you as the Assignee on the task 👍

mkw2000 commented 7 years ago

@moollaza Thank you , just joined !