duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Currency: Add "yuan" as alias for Chinese Yuan #3220

Closed moollaza closed 7 years ago

moollaza commented 7 years ago

Problem

The word yuan should exist as an alias for "Chinese Yuan" (which seems to be the most popular Peso) in currencyNames.txt.

From user feedback and unanswered query data, we can see that this is something we need.

This issue would be perfect for a newcomer who hasn't yet contributed to DuckDuckHack!

Solution

  1. Add 2 or 3 tests to t/Currency.t
    • e.g. 1 yuan to usd
  2. Add the aliases in currencyNames.txt
  3. Verify tests pass by running duckpan test currency
  4. Send Pull Request

People to notify

@pjhampton

Get Started

Resources


Instant Answer Page: https://duck.co/ia/view/currency

adityatandon007 commented 7 years ago

@moollaza I would like to try

pjhampton commented 7 years ago

Thanks @adityatandon007 💙 💛 💜