search

duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

"the hobbit book review" not showing anything #332

Closed jagtalon closed 10 years ago

jagtalon commented 10 years ago

The Book instant answer should be triggering and showing a result.

moollaza commented 10 years ago

Looks like its triggering the spice and the API does return the correct result first. It must be getting thrown out by stringsRelevant()

https://duckduckgo.com/?q=the+hobbit+book+review https://duckduckgo.com/js/spice/book/the%20hobbit

jagtalon commented 10 years ago

Yeah, and maybe "the" is also getting skipped (not sure if I set minwordlength). Should work, though--I tried running DDG.isRelevant("THE HOBBIT - or There and Back Again") and I got true.

moonlightdrive commented 10 years ago

I don't believe the "the" is a problem, because "the giver book review" works as expected

However when I ran DDG.isRelevant("THE HOBBIT - or There and Back Again") I got false Though I'm not sure why this would differ from what @jagtalon got?

jagtalon commented 10 years ago

Book is currently not live so I'm closing this for now because it's not actionable. Book needs to relaunch https://github.com/duckduckgo/zeroclickinfo-spice/issues/955